Added kwargs to capture method #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yurasavin We greatly appreciate your valuable contribution. Could you also incorporate some test cases? Our goal is to ensure that each change is thoroughly tested before merging. |
|
@aashishgurung |
@yurasavin Thank you for providing some tests for your changes. As you can see the test is failing so it would be appreciated if you can please modify your test for it to pass. |
AnasNaouchi
reviewed
Sep 25, 2023
AnasNaouchi
approved these changes
Oct 2, 2023
aashishgurung
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! It's not possible to perform partial capture with python SDK since
capturemethod doesn't accept any params. This patch fix it