Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destroy method for Link #39

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Add destroy method for Link #39

merged 1 commit into from
Jan 26, 2021

Conversation

som-m
Copy link
Contributor

@som-m som-m commented Jan 26, 2021 •
edited
Loading

Summary

  • Add destroy method for Link (Omise doc)
  • Add test

QA

You should be able to destroy a link.

  1. Retrieve a link
    link = omise.Link.retrieve('link_test_5ll4klw6mopf4nh4bi5')

  2. Destroy the link
    link.destroy()

  3. Check whether the link has been destroyed
    link.destroyed

@keeratita keeratita self-requested a review January 26, 2021 03:53
@som-m som-m changed the title add link destroy Add destroy method for Link Jan 26, 2021
@keeratita
Copy link

tested python setup.py test -q .. they are all passed.

@keeratita keeratita merged commit f8e90b3 into omise:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezigned rezigned rezigned approved these changes

@danfowler danfowler danfowler approved these changes

@keeratita keeratita keeratita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@som-m @keeratita @rezigned @danfowler