Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGA3-846] : Support secure protocol and user agent #175

Merged

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Jan 25, 2023

Purpose

Support secure protocol and user agent in omise config

https://opn-ooo.atlassian.net/browse/ENGA3-846

Description

  • Added docs/pull_request_template.md
  • Added support for userAgent in omise config options
  • Added support for OMISE_SECURE_PROTOCOL env variable to switch over http and https
    OMISE_SECURE_PROTOCOL=http node main.js or
var config = {
    ...
    secureProtocol: 'http',
    userAgent: 'Shopify-Payments-App/v1.9.1'
};

Checklist

  • I have applied development best practices
  • I am following the change management guidelines
  • If my change require, I have updated the documentation accordingly. [PCI DSS 6.5.6]
  • The default rollback procedure can be used. [PCI DSS 6.5.5.4]
  • All relevant quality testing is being done. [PCI DSS 6.4.5.3]
  • The correct people are assigned to review the pull request. [PCI DSS 6.4.5.2]
  • There is no business impact planned. [PCI DSS 6.4.5.1]
  • The correct labels such as minor, medium, major have been added.
  • If this is a significant change, security team have reviewed the change. [PCI DSS 6.4.6]
  • No manual Pre or Post deployment steps needed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ajzkk ajzkk merged commit 0047160 into master Jan 26, 2023
@ajzkk ajzkk deleted the feature/ENGA3-846-support-secure-protocol-and-user-agent branch January 26, 2023 06:28
@ajzkk ajzkk mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants