Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to disable internal send and receive spans #1

Closed
wants to merge 3 commits into from

Conversation

omgitsaheadcrab
Copy link
Owner

@omgitsaheadcrab omgitsaheadcrab commented Aug 16, 2024

Description

This PR addresses the issue where it is not possible to disable internal HTTP send and receive spans. For many members of the community these do not provide any value and only add noise to the traces. Other mechanisms of filtering them out, such as wrapping span processors or exporters are clunky.

Providing environment variables, namely: OTEL_PYTHON_ASGI_EXCLUDE_SEND_SPAN and OTEL_PYTHON_ASGI_EXCLUDE_RECEIVE_SPAN allows users to disable one or both of these with no additional code.

Fixes open-telemetry#831

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TestAsgiApplication.test_exclude_internal_spans added to test logic
  • [X Integration tests performed manually using the environment variables

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastApi auto-instrumentation send extra spans for a single API execution
1 participant