Dev configpod logs #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thakurajayL
reviewed
Oct 17, 2021
thakurajayL
reviewed
Oct 17, 2021
thakurajayL
reviewed
Oct 17, 2021
proto/server/1
Outdated
| @@ -0,0 +1,1073 @@ | |||
| // SPDX-FileCopyrightText: 2021 Open Networking Foundation <[email protected]> | |||
There was a problem hiding this comment.
Remove this file. Looks like temp file.
thakurajayL
reviewed
Oct 17, 2021
proto/server/clientEvtHandler.go
Outdated
| client.devgroupsConfigClient[configMsg.DevGroupName] = configMsg.DevGroup | ||
| } else if configMsg.DevGroupName != "" && configMsg.MsgMethod == configmodels.Delete_op { | ||
| lastDevGroup = client.devgroupsConfigClient[configMsg.DevGroupName] | ||
| client.clientLog.Infof("Received delete configuration for device Group %v ", configMsg.DevGroupName) | ||
| client.clientLog.Debugf("Deleted device Group %v ", configMsg.DevGroupName) |
There was a problem hiding this comment.
Original log content was good. Just changing logging level is good enough.
thakurajayL
reviewed
Oct 17, 2021
proto/server/clientEvtHandler.go
Outdated
| client.slicesConfigClient[configMsg.SliceName] = configMsg.Slice | ||
| } else if configMsg.SliceName != "" && configMsg.MsgMethod == configmodels.Delete_op { | ||
| client.clientLog.Infof("Received delete configuration for slice %v ", configMsg.SliceName) | ||
| client.clientLog.Debugf("Deleted slice %v ", configMsg.SliceName) |
There was a problem hiding this comment.
Original log content is good. Just change logging level.
thakurajayL
reviewed
Oct 17, 2021
proto/server/clientEvtHandler.go
Outdated
|
|
||
| if len(sliceConfig.SiteDeviceGroup) == 0 { |
There was a problem hiding this comment.
Can you put these changes in other change request ? Will this cause any impact ?
thakurajayL
reviewed
Oct 17, 2021
thakurajayL
reviewed
Oct 17, 2021
proto/server/clientEvtHandler.go
Outdated
| for _, val := range imsis { | ||
| deleteConfigHss(client, val) | ||
| } | ||
| dimsis := getDeletedImsiList(lastDevGroup, devGroup) |
There was a problem hiding this comment.
avoid changing this area. There is bug in this code. Keep this pull request only for logs.
thakurajayL
reviewed
Oct 17, 2021
thakurajayL
reviewed
Oct 17, 2021
vthiruveedula
force-pushed
the
dev-configpod-logs
branch
from
ab29055 to
e9857c5
Compare
|
test container |
vthiruveedula
force-pushed
the
dev-configpod-logs
branch
from
e9857c5 to
0a69d49
Compare
thakurajayL
reviewed
Oct 19, 2021
thakurajayL
reviewed
Oct 19, 2021
thakurajayL
reviewed
Oct 19, 2021
thakurajayL
reviewed
Oct 19, 2021
| @@ -670,6 +676,10 @@ func deletedImsis(prev, curr *configmodels.DeviceGroups) (imsis []string) { | |||
| return prev.Imsis | |||
| } | |||
|
|
|||
| if prev == nil { | |||
There was a problem hiding this comment.
may be you need to run format on these files
… into dev-configpod-logs
vthiruveedula
force-pushed
the
dev-configpod-logs
branch
from
0a69d49 to
6902f40
Compare
thakurajayL
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.