feat: propagate Subscriber deletion to Device Groups

configapi/api_sub_config.go

@@ -12,6 +12,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"strings"
 
 	"github.com/gin-gonic/gin"
 	"github.com/omec-project/openapi/models"
@@ -268,9 +269,12 @@ func GetSubscribers(c *gin.Context) {
 	logger.WebUILog.Infoln("Get All Subscribers List")
 
 	var subsList []configmodels.SubsListIE
+	subsList = make([]configmodels.SubsListIE, 0)
 	amDataList, errGetMany := dbadapter.CommonDBClient.RestfulAPIGetMany(amDataColl, bson.M{})
 	if errGetMany != nil {
-		logger.DbLog.Warnln(errGetMany)
+		logger.DbLog.Errorw("failed to retrieve subscribers list", "error", errGetMany)
+		c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to retrieve subscribers list"})
+		return
 	}
 	for _, amData := range amDataList {
 
@@ -483,17 +487,61 @@ func DeleteSubscriberByID(c *gin.Context) {
 
 	ueId := c.Param("ueId")
 
-	c.JSON(http.StatusNoContent, gin.H{})
+	imsi := strings.TrimPrefix(ueId, "imsi-")
+	err := updateSubscriberInDeviceGroups(imsi)
+	if err != nil {
+		c.JSON(http.StatusInternalServerError, gin.H{"error": "error deleting subscriber"})
+		return
+	}
 
 	msg := configmodels.ConfigMessage{
 		MsgType:   configmodels.Sub_data,
 		MsgMethod: configmodels.Delete_op,
 		Imsi:      ueId,
 	}
 	configChannel <- &msg
+	c.JSON(http.StatusNoContent, gin.H{})
 	logger.WebUILog.Infoln("Delete Subscriber Data complete")
 }
 
+func updateSubscriberInDeviceGroups(imsi string) error {
+	filterByImsi := bson.M{
+		"imsis": imsi,
+	}
+	rawDeviceGroups, err := dbadapter.CommonDBClient.RestfulAPIGetMany(devGroupDataColl, filterByImsi)
+	if err != nil {
+		logger.DbLog.Errorf("failed to fetch device groups: %v", err)
+		return err
+	}
+	var deviceGroupUpdateMessages []configmodels.ConfigMessage
+	for _, rawDeviceGroup := range rawDeviceGroups {
+		var deviceGroup configmodels.DeviceGroups
+		if err = json.Unmarshal(configmodels.MapToByte(rawDeviceGroup), &deviceGroup); err != nil {
+			logger.DbLog.Errorf("error unmarshaling device group: %v", err)
+			return err
+		}
+		filteredImsis := []string{}
+		for _, currImsi := range deviceGroup.Imsis {
+			if currImsi != imsi {
+				filteredImsis = append(filteredImsis, currImsi)
+			}
+		}
+		deviceGroup.Imsis = filteredImsis
+		deviceGroupUpdateMessage := configmodels.ConfigMessage{
+			MsgType:      configmodels.Device_group,
+			MsgMethod:    configmodels.Post_op,
+			DevGroupName: deviceGroup.DeviceGroupName,
+			DevGroup:     &deviceGroup,
+		}
+		deviceGroupUpdateMessages = append(deviceGroupUpdateMessages, deviceGroupUpdateMessage)
+	}
+	for _, msg := range deviceGroupUpdateMessages {
+		configChannel <- &msg
+		logger.WebUILog.Infof("device group [%v] update sent to config channel", msg.DevGroupName)
+	}
+	return nil
+}
+
 func GetRegisteredUEContext(c *gin.Context) {
 	setCorsHeader(c)