-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: propagate inventory edition to NS DB and NFs #297
Merged
ghislainbourgeois
merged 10 commits into
omec-project:main
from
patriciareinoso:edit-gnb
Jan 30, 2025
Merged
feat: propagate inventory edition to NS DB and NFs #297
ghislainbourgeois
merged 10 commits into
omec-project:main
from
patriciareinoso:edit-gnb
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patricia Reinoso <[email protected]>
patriciareinoso
commented
Jan 27, 2025
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
I found 2 issues with this PR. I put it back to draft |
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
patriciareinoso
changed the title
feat: implement edit gNB
feat: propagate inventory edition to NS DB and NFs
Jan 30, 2025
all fixed, ready for review again. |
ghislainbourgeois
approved these changes
Jan 30, 2025
Merged
7 tasks
Testing with NMS integrations I see the propagation to NFs message is sent
and the pebble notice
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the edition of gNBs.
Given that we can create a NS containing a gNB before or after the creation of a gNB object, the PUT and the POST gNB operations are propagated to the NS containing it.
Edition of gNB is propagated to Network slices containing a gNB with the given name. For this, we send a message in the
configChannel
. Like this, the operation update will be executed inwebconsole/proto/server/clientEvtHandler.go
and the corresponding pebble notice will be sent. After that, it will be sent to the clients in the grpc server.We use transactions to ensure that both DB updates are successfully executed or reverted.
This PR also modifies #278 to ensure that the modification is propagated correctly instead of just updating the DB