-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Delete DG operation, remove the DG from the NS list #291
Closed
patriciareinoso
wants to merge
12
commits into
omec-project:main
from
patriciareinoso:TELCO-1557-delete-dg-from-ns
Closed
feat: Delete DG operation, remove the DG from the NS list #291
patriciareinoso
wants to merge
12
commits into
omec-project:main
from
patriciareinoso:TELCO-1557-delete-dg-from-ns
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patricia Reinoso <[email protected]>
ec03e55
to
36c0f60
Compare
patriciareinoso
commented
Jan 21, 2025
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
patriciareinoso
commented
Jan 22, 2025
patriciareinoso
commented
Jan 22, 2025
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When we DELETE a device group, information is removed from
webconsoleData.snapshots.devGroupData
. However, if a network slice contains a reference to this device group insite-device-group
, the reference is not removed.When the new config if sent to the NFs clients we get the following logs:
Example for SMF:
Example for NFs that require metadata (PCF):
Which means that the message is either not sent or incomplete. The reason:
fillSlice
function fails if the NS contains a reference to a DG that does not exist.Description
This PR propagates the DELETE device group operation to the network slice that contains the deleted device group. This way, the removal of the DG is done in 1 operation, no need to manually post the network slice to remove the dangling reference anymore.
How the code works
Webconsole behavior on Device Group POST before this PR
When a device group is created (POST) and it belong to a NS. It creates entries for each subscriber in:
subscriptionData.provisionedData.smData
subscriptionData.provisionedData.smfSelectionSubscriptionData
policyData.ues.amData
policyData.ues.smData
And update the information in
subscriptionData.provisionedData.amData
Webconsole behavior on Device Group DELETE before this PR
When a device group is deleted (DELETE) and it belong to a NS. It removes entries for each subscriber in:
subscriptionData.provisionedData.smData
subscriptionData.provisionedData.smfSelectionSubscriptionData
policyData.ues.amData
policyData.ues.smData
subscriptionData.provisionedData.amData
This PR
subscriptionData.provisionedData.amData
to remove only the fields that it added. Since this entry is created in POST subscriber operation. Otherwise, the subscriber can no longer be retrieved by theGET {webconsole}/api/subscriber
.webconsole/proto/server/configEvtHandler.go
How to see the behavior
subscriptionData.provisionedData.smData
subscriptionData.provisionedData.smfSelectionSubscriptionData
policyData.ues.amData
policyData.ues.smData
subscriptionData.provisionedData.amData
subscriptionData.authenticationData.authenticationSubscription
You should see:
subscriptionData.provisionedData.smData
subscriptionData.provisionedData.smfSelectionSubscriptionData
policyData.ues.amData
policyData.ues.smData
subscriptionData.provisionedData.amData
(ueID)subscriptionData.authenticationData.authenticationSubscription
GET Subscriber returns the subscriber with only AccessAndMobilitySubscriptionData (ueID) and AuthenticationSubscription
In the logs: in the messages sent to the NFs you should no longer see this line:
Instead, they should look like: