Refactor path for configuration file, option(s) and Docker image #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arrobo, Gabriel <[email protected]>
|
As such looks good.. Will this break any other work for Canonical? |
I do not think this should break anything. However, I can double check with them. The changes here are consistent with the other NFs. So, if these changes break something on the Canonical side, the changes in all of the other NFs will have similar effect |
gab-arrobo
commented
Nov 2, 2024
Signed-off-by: Arrobo, Gabriel <[email protected]>
|
@patriciareinoso, any objection/comment about this PR? |
|
We are currently using |
|
@patriciareinoso its not just webconsole but also other NFs have gone through similar change. |
thakurajayL
approved these changes
Nov 4, 2024
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.