Refactor

omec-project · Mar 10, 2022 · df35a46 · df35a46
1 parent 78a8373
commit df35a46
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 10 deletions.
diff --git a/pkg/pfcpsim/session/qer_builder.go b/pkg/pfcpsim/session/qer_builder.go
@@ -6,16 +6,16 @@ package session
 import "github.com/wmnsk/go-pfcp/ie"
 
 type qerBuilder struct {
-	method   IEMethod
-	qerID    uint32
-	qfi      uint8
-	isMbrSet bool
-	ulMbr    uint64
-	dlMbr    uint64
-	isGbrSet bool
-	ulGbr    uint64
+	method     IEMethod
+	qerID      uint32
+	qfi        uint8
+	isMbrSet   bool
+	ulMbr      uint64
+	dlMbr      uint64
+	isGbrSet   bool
+	ulGbr      uint64
 	dlGbr      uint64
-	gateStatus GateStatus
+	gateStatus uint8
 
 	isIDSet bool
 }

diff --git a/pkg/pfcpsim/session/qer_builder_test.go b/pkg/pfcpsim/session/qer_builder_test.go
@@ -54,7 +54,20 @@ func TestQERBuilder(t *testing.T) {
 				ie.NewQFI(2),
 				ie.NewGateStatus(0, 0),
 			),
-			description: "Valid Create QER",
+			description: "Valid Create QER with gate open",
+		},
+		{
+			input: NewQERBuilder().
+				WithID(1).
+				WithMethod(Create).
+				WithQFI(2).
+				WithGateStatus(ie.GateStatusClosed),
+			expected: ie.NewCreateQER(
+				ie.NewQERID(1),
+				ie.NewQFI(2),
+				ie.NewGateStatus(1, 1),
+			),
+			description: "Valid Create QER with Gate closed",
 		},
 		{
 			input: NewQERBuilder().