Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up DPDK version to 22.11 #39

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Bump up DPDK version to 22.11 #39

merged 4 commits into from
Mar 7, 2024

Conversation

gab-arrobo
Copy link
Contributor

@gab-arrobo gab-arrobo commented Jan 31, 2024 •
edited
Loading

Changes were tested deploying the UPF in standalone mode.

@gab-arrobo gab-arrobo mentioned this pull request Feb 1, 2024
Merged
@gab-arrobo gab-arrobo marked this pull request as draft February 1, 2024 03:14
@gab-arrobo gab-arrobo force-pushed the dpdk-22-11 branch 6 times, most recently from b7a8d14 to 0c40b16 Compare February 15, 2024 05:36
@gab-arrobo gab-arrobo closed this Feb 29, 2024
@gab-arrobo gab-arrobo reopened this Feb 29, 2024
@gab-arrobo gab-arrobo marked this pull request as ready for review February 29, 2024 18:42
@gab-arrobo gab-arrobo requested a review from amarsri28 February 29, 2024 18:48
ghislainbourgeois
ghislainbourgeois reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, I will take some time tomorrow to test a deployment with DPDK.

core/drivers/pmd.cc Outdated Show resolved Hide resolved
@markbeierl
Copy link

I have tested this against a problematic VM using virtio. Under 20.11, DPDK was not able to initialize the hardware. Now with 22.11, I can confirm this patch works on newer hardware.

@markbeierl
Copy link

One more thing to report: this update allowed me to run a simulation performance test for a much longer time and I did not see the UE connection drop as I usually do during heavy load.

@ghislainbourgeois
Copy link
Contributor

My tests were also successful, but I was only able to use virtual NICs.

@gab-arrobo
Copy link
Contributor Author

My tests were also successful, but I was only able to use virtual NICs.

FYI, I tested the changes using physical NICs (E810)

@gab-arrobo
Copy link
Contributor Author

One more thing to report: this update allowed me to run a simulation performance test for a much longer time and I did not see the UE connection drop as I usually do during heavy load.

@markbeierl, thanks for your input!

@gab-arrobo gab-arrobo mentioned this pull request Mar 2, 2024
Closed
sureshmarikkannu
sureshmarikkannu previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@sureshmarikkannu sureshmarikkannu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

amarsri28
amarsri28 reviewed Mar 4, 2024
View reviewed changes
core/drivers/pmd.cc Outdated Show resolved Hide resolved
amarsri28
amarsri28 reviewed Mar 4, 2024
View reviewed changes
core/drivers/pmd.cc Outdated Show resolved Hide resolved
amarsri28
amarsri28 reviewed Mar 4, 2024
View reviewed changes
build.py Show resolved Hide resolved
amarsri28
amarsri28 reviewed Mar 4, 2024
View reviewed changes
build.py Show resolved Hide resolved
@markbeierl
Copy link

Confirmed retesting in my virtual environment has the same positive result with the latest changes.

sureshmarikkannu
sureshmarikkannu approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@sureshmarikkannu sureshmarikkannu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the bess build and upf and changes looks good.

@gab-arrobo gab-arrobo merged commit dc7ef58 into omec-project:master Mar 7, 2024
9 checks passed
@gab-arrobo gab-arrobo deleted the dpdk-22-11 branch March 7, 2024 17:53
@AldericoGallo AldericoGallo mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshmarikkannu sureshmarikkannu sureshmarikkannu approved these changes

@amarsri28 amarsri28 amarsri28 approved these changes

@markbeierl markbeierl markbeierl approved these changes

@badhrinathpa badhrinathpa Awaiting requested review from badhrinathpa

@ghislainbourgeois ghislainbourgeois Awaiting requested review from ghislainbourgeois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gab-arrobo @markbeierl @ghislainbourgeois @amarsri28 @sureshmarikkannu