Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action for checking code format (C/C++ and Protobuf) #15

Merged
merged 7 commits into from
Feb 19, 2023
Merged

Add GitHub Action for checking code format (C/C++ and Protobuf) #15

merged 7 commits into from
Feb 19, 2023

Conversation

gab-arrobo
Copy link
Contributor

This PR adds a GitHub Action for checking code formatting (C/C++ and Protobuf).
These are the details of this PR:

  • Add GitHub Action to check code formatting
    • Uses clang-format-12
  • The .clang-format file was moved from the core directory to the root directory for the GitHub Action to use
  • The format for ~70 file was updated

@thakurajayL thakurajayL merged commit 4b3a40d into omec-project:dpdk-2011-focal Feb 19, 2023
@gab-arrobo gab-arrobo deleted the gh-action-format branch February 19, 2023 03:32
gab-arrobo added a commit that referenced this pull request Jun 20, 2023
@gab-arrobo @krsna1729
@thakurajayL @amolonf @badhrinathpa @manojgop
Moving all changes we have made from the dpdk-2011-focal branch to …
0190223 
…the `master` branch (#21)

* Upgrade DPDK to 20.11

- address memseg and mbuf changes
- move to meson/ninja build system

Signed-off-by: Saikrishna Edupuganti <[email protected]>

* Update DPDK version to 20.11.3

ice ddp loading seems reliable when using a PF with this version

Signed-off-by: Saikrishna Edupuganti <[email protected]>

* Allow override of base image with IMAGE

IMAGE="ghcr.io/omec-project/upf-epc/bess_build" \
./container_build.py shell

Signed-off-by: Saikrishna Edupuganti <[email protected]>

* Use focal base image

Signed-off-by: Saikrishna Edupuganti <[email protected]>

* 0001-Add-2-workers-support-to-Nat-module

* 0002-Use-same-rss-key-across-interfaces

* 0003-Add-FIB-routing-support-in-IPLookup-module

* 0004-IOVA-mode-correction

* 0005-Expose-PMDPort-socket-memory-allocation

* 0006-Add-switch-for-promiscuous-mode

* 0008-Enable-hardware-checksum-offload

* 0009-Adding-value-attributes-to-ExactMatch-WildcardMatch

* 0010-Add-hardware-rx-checksum-offload-option-for-checksum

* 0011-Protobuf-update-to-new-module-messages

* 0012-Dpdk-concurrent-hash-support-pipeline-improvement

* 0013-Use-rte_flow_create-to-do-GTPU-RSS

* 0014-Add-ice-iavf-to-list-of-drivers-need-SW-port-stats

* 0015-Protobuf-changes-for-Qos

* 0016-Newer-versions-require-go_package-stated-in-proto

* 0017-Make-table-sizes-configurable

* 0017-QoS-Measure

* 0018-Increase-max-tuple-num

* 0019-GUI-dot-module-name-quote

* Removed deprecated DPDK options/functions

* Remove unnecesary `endl`

* Fix a couple typos

* Remove unused variables

* No need to use `move`

* Improve code

* Fix Doxygen for AddMetadataAttr method

* Bring DPDK patch from UPF

* Move BESS-related files to BESS repo

* Bring BESS scripts from UPF repo

* Update links to reference ONF's BESS

* Remove unnecesary `endl` in loggings

* Fix stringstream

* Fix format in files

* Add override keyword and remove unused attribute

* Ubuntu Focal includes this package

* Update CXXFLAGS to work with g++ and clang

* Explicitily include server_builder.h

* Temporarily disabling some tests due to changes made in UPF.
Need to address the issues one by one

* Add missing header file <linux/ethtool.h>

* Use `bytes` for the scapy packets due to problems when using `str`

* Moving to python3 due to Python2 EOL
These changes are needed to be able to build and test bess with GitHub Actions

* Use ghcr.io/omec-project/upf-epc/bess_build for the BESS dependencies
This bess_build includes the changes needed to build DPDK 20.11

* Add GitHub Action that will trigger the Build and Test process
Additionally, remove Travis.yml file that is not needed anymore

* Create pull_request.yaml

* Update README.md

test the workflow

* Remove unnecessary file

* Update sugar.py

* Action for dependabot and check license/copyright (#14)

* Action for dependabot and check license/copyright

* Remove empty line

* Add empty line at end of file

* Add GitHub Action for checking code format (C/C++ and Protobuf) (#15)

* Add GitHub Action for checking code format (C/C++ and Protobuf)

* Update GitHub Action to only remove the OS from the matrix

* Address issues with format compliance for protobuf files

* Add missing file that was not formatted

* Update parameters for GitHub Action

* Add missing license/copyright header and add an exception

* Refactor define for the GTPu header (#16)

* Update GitHub Action to build docker image locally (#18)

- Update GitHub Actions to build docker image locally during pull request
- Use protobuf version 3.20 to fix errors in generated _pb2.py file

Signed-off-by: Manoj Gopalakrishnan <[email protected]>

* Add support for CNDP(Cloud Native Data Plane) port in BESS. (#2)

- CNDP BESS port to send/receive n/w packets using AF_XDP socket.
- Modify Bess core Makefile to build CNDP port driver.
- Dockerfile to build BESS with CNDP.
- Add "CndpPortArg" in port_msg.proto file to initialize Bess CNDP port.
- Use external BESS PacketPool (rte_mempool/rte_mbuf) with CNDP xskdev.
- Example scripts to test Bess CNDP port.
- ReadMe file to build docker image and run BESS CNDP example scripts.
- GitHub Action for running CNDP tests.

Signed-off-by: Manoj Gopalakrishnan <[email protected]>

* Build new image taking into account new dependencies (e.g., CNDP) (#22)

* Fix typo (#17)

* Enable GTPu path monitoring (#19)

* Enable GTPu path monitoring

* Update pktbatch.h (#24)

---------

Signed-off-by: Saikrishna Edupuganti <[email protected]>
Signed-off-by: Manoj Gopalakrishnan <[email protected]>
Co-authored-by: Saikrishna Edupuganti <[email protected]>
Co-authored-by: Ajay Lotan Thakur <[email protected]>
Co-authored-by: Ajay Lotan Thakur <[email protected]>
Co-authored-by: Amol Jaikar <[email protected]>
Co-authored-by: Badhrinath <[email protected]>
Co-authored-by: manojgop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badhrinathpa badhrinathpa Awaiting requested review from badhrinathpa

@thakurajayL thakurajayL Awaiting requested review from thakurajayL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gab-arrobo @thakurajayL