Skip to content

Commit

Permalink
Rebase default branch (dpdk-2011-focal) (#33)
Browse files Browse the repository at this point in the history
* Ensure that kMaxBurst is explicitly defined

kMaxBurst was declared and assigned a value, but not explicitly defined. This can cause issues when linking in cases where a reference
may be taken of kMaxBurst (say, passing it to std::min()) and the constant can't be fully optimized out.

This was actually fixed years ago in #522 but ended up being reverted accidentally during a refactor in #820.

With C++17 now, we don't have to put the definition in a source file, we can just add inline and that takes care of it.
  • Loading branch information
gab-arrobo authored Jan 9, 2024
1 parent 4c03c9b commit 557237a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ To install BESS on Linux quickly, you can download the binary from [Release](htt
make -C core/kmod # Build the kernel module (optional)
bessctl/bessctl

Documentation can be found [here](https://github.com/omec-project/bess/wiki/). Please consider [contributing](https://github.com/omec-project/bess/wiki/How-to-Contribute) to the project!!
Documentation can be found [here](https://github.com/omec-project/bess/wiki/). Please consider [contributing](https://github.com/omec-project/bess/wiki/How-to-Contribute) to the project!

0 comments on commit 557237a

Please sign in to comment.