Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Cap requests version below 2.12.2 #204

Merged
merged 2 commits into from
Dec 6, 2016
Merged

Cap requests version below 2.12.2 #204

merged 2 commits into from
Dec 6, 2016

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Nov 30, 2016

Last release seems to have broken docker-py /cc @joshmoore @aleksandra-tarkowska

See ansible/ansible-modules-core#5775 and
https://github.com/kennethreitz/requests/issues/3734 for the relevant issues

@joshmoore
Copy link
Member

I'm still having issues with this:

RUNNING HANDLER [devspace : docker_service] ************************************
fatal: [adhoc-devspace]: FAILED! => {"changed": false, "failed": true, "msg": "Error: docker-py version is 1.10.6. Minimum version required is 1.7.0."}

atarkowska
atarkowska reviewed Dec 1, 2016
View reviewed changes
Copy link
Member

@atarkowska atarkowska left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

(dev_tools) MacBookPro:ansible ola$ ansible-playbook os-devspace.yml -e vm_name=ola-test-deps -e vm_key_name=ola

PLAY [localhost] ***************************************************************

TASK [setup] *******************************************************************
ok: [localhost]
...
TASK [debug] *******************************************************************
ok: [localhost] => {
    "msg": "IPs (Docker) private:192.168.1.110 floating:10.0.51.107"
}

PLAY RECAP *********************************************************************
localhost                  : ok=5    changed=1    unreachable=0    failed=0   

(dev_tools) MacBookPro:ansible ola$ ansible-playbook -l ola-test-deps -u centos devspace.yml 
statically included: /Users/ola/OMERO/SYSADMIN/management_tools/infrastructure/ansible/roles/devspace/tasks/devspace-install.yml
Secure Jenkins with password (username: devspace): 

PLAY [devspace] ****************************************************************

TASK [setup] *******************************************************************
ok: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [upgrade-distpackages : system packages | upgrade] ************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=[u'*'])

TASK [upgrade-distpackages : system | current running kernel] ******************
ok: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [upgrade-distpackages : system | latest installed kernel] *****************
ok: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]
 [WARNING]: Consider using yum, dnf or zypper module rather than running rpm


TASK [upgrade-distpackages : system | check if reboot needed] ******************
ok: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [upgrade-distpackages : debug] ********************************************
ok: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => {
    "msg": "Reboot needed (kernel): Current:3.10.0-327.22.2.el7.x86_64 Latest:3.10.0-327.36.3.el7.x86_64"
}

TASK [upgrade-distpackages : system | reboot] **********************************
skipping: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [upgrade-distpackages : system | wait for server to reboot] ***************
skipping: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [lvm-partition : storage | create logical volume] *************************
skipping: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [lvm-partition : storage | format] ****************************************
skipping: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [lvm-partition : storage | mount] *****************************************
skipping: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [docker : upstream docker | setup repository] *****************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [docker : upstream docker | install docker] *******************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [docker : storage | setup lvm docker-pool] ********************************
skipping: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [docker : upstream docker | configure docker options] *********************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [docker : upstream docker | copy systemd file] ****************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [docker : upstream docker | reload systemd] *******************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [docker : docker | enable] ************************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [docker : docker | group members] *****************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=centos)

TASK [versioncontrol-utils : system packages | install epel repo] **************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [versioncontrol-utils : system packages | basic system utils] *************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=[u'git'])

TASK [devspace : add user omero to docker group] *******************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : ensures /home/omero/.ssh dir exists] **************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : allow omero to ssh directly] **********************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : install python tools] *****************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=[u'python-devel', u'python-pip'])

TASK [devspace : install python packages] **************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=pip)
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=passlib)
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=pyyaml)
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=docker-compose)

TASK [devspace : TODO install docker-py] ***************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=docker-py==1.9.0)
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=requests<2.12.2)

TASK [devspace : clone devspace] ***********************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : ensures .ssh dir exists] **************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : copy snoopy] **************************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item={u'dest': u'.ssh/config', u'srcfile': u'.ssh/config'})
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item={u'dest': u'.ssh/snoopycrimecop_github', u'srcfile': u'.ssh/snoopycrimecop_github'})
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item={u'dest': u'.ssh/snoopycrimecop_github.pub', u'srcfile': u'.ssh/snoopycrimecop_github.pub'})
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item={u'dest': u'.gitconfig', u'srcfile': u'.gitconfig'})

TASK [devspace : known_hosts] **************************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : chmod known_hosts] ********************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : change USER_ID] ***********************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=bf/Dockerfile)
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=nginx/Dockerfile)
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=slave/Dockerfile)
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=server/Dockerfile)
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=web/Dockerfile)

TASK [devspace : set basic auth password for jenkins] **************************
skipping: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : set basic auth password for jenkins] **************************
skipping: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : set jenkins password] *****************************************
skipping: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : ssl cert for jenkins] *****************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : ssl cert for nginx] *******************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : rename to develop...] *****************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

TASK [devspace : fix jenkinsUrl] ***********************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => (item=jenkins.model.JenkinsLocationConfiguration.xml)

RUNNING HANDLER [docker : restart docker] **************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

RUNNING HANDLER [devspace : restart devspace] **********************************
included: /Users/ola/OMERO/SYSADMIN/management_tools/infrastructure/ansible/roles/devspace/tasks/devspace-runtime.yml for e18bf8ad-2ea1-4698-8aea-fb5de2bd2952

RUNNING HANDLER [devspace : docker_service] ************************************
ok: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

RUNNING HANDLER [devspace : docker_service] ************************************
changed: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

RUNNING HANDLER [devspace : debug] *********************************************
ok: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952] => {
...
}

RUNNING HANDLER [devspace : assert] ********************************************
ok: [e18bf8ad-2ea1-4698-8aea-fb5de2bd2952]

PLAY RECAP *********************************************************************
e18bf8ad-2ea1-4698-8aea-fb5de2bd2952 : ok=37   changed=28   unreachable=0    failed=0

ansible/roles/devspace/tasks/devspace-install.yml
# Temporary fix - cap requests to version below 2.12.2
# See https://github.com/kennethreitz/requests/issues/3734 and
# https://github.com/docker/docker-py/issues/1321
- requests<2.12.2
Copy link
Member

@atarkowska atarkowska Dec 1, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is not needed here, one below is enough

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my diff was:

$ git diff
diff --git a/ansible/roles/devspace/tasks/devspace-install.yml b/ansible/roles/devspace/tasks/devspace-install.yml
index b4bd39b..c6e69b4 100644
--- a/ansible/roles/devspace/tasks/devspace-install.yml
+++ b/ansible/roles/devspace/tasks/devspace-install.yml
@@ -59,6 +59,7 @@
     state: latest
   with_items:
     - docker-py==1.9.0
+    - requests<2.12.2
 
 - name: clone devspace
   become: yes

@manics
Copy link
Member

manics commented Dec 5, 2016

You've added:

  • ansible/.clouds.cache
  • ansible/plugins/callback/error_if_no_hosts_match.pyc

@sbesson sbesson force-pushed the requests_2.12.2_cap branch from 7842083 to 1d3c02d Compare December 5, 2016 09:39
@sbesson
Copy link
Member Author

sbesson commented Dec 5, 2016

Thanks @manics force pushed.

@joshmoore
Copy link
Member

Merging since this seems to work for @aleksandra-tarkowska. I'll keep trying.

@joshmoore joshmoore merged commit 3f9e06b into ome:master Dec 6, 2016
@sbesson sbesson deleted the requests_2.12.2_cap branch December 6, 2016 08:20
atarkowska
atarkowska reviewed Dec 6, 2016
View reviewed changes
ansible/roles/devspace/tasks/devspace-install.yml
@@ -59,6 +59,8 @@
state: latest
with_items:
- docker-py==1.9.0
# Same as above
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm where is above? :)

Copy link
Member

@atarkowska atarkowska Dec 6, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

+    # Temporary fix - cap requests to version below 2.12.2
+    # See https://github.com/kennethreitz/requests/issues/3734 and
+    # https://github.com/docker/docker-py/issues/1321

could be added with the next opened PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atarkowska atarkowska atarkowska left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbesson @joshmoore @manics @atarkowska