Declare variables global/local #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thank you! |
These aren't in functions so won't cause warnings normally, but they can do if zshrc.sh is sourced from inside a function
|
@olivierverdier any chance we can get this merged? |
| GIT_CHANGED=$__CURRENT_GIT_STATUS[6] | ||
| GIT_UNTRACKED=$__CURRENT_GIT_STATUS[7] | ||
|
|
||
| typeset -ga __CURRENT_GIT_STATUS=("${(@s: :)_GIT_STATUS}") |
There was a problem hiding this comment.
I get an error on this line: no matches found: __CURRENT_GIT_STATUS=(). I don't know enough zsh to understand that...
There was a problem hiding this comment.
@olivierverdier Python or Haskell?
There was a problem hiding this comment.
My guess is this is happening because _GIT_STATUS is empty, but I can't see why this change would have affected that…
|
As is probably obvious, I don’t plan on working on this any more :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused warnings with
setopt warn_create_global