don't use error message but check returncode of the command #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Hello @olivierverdier |
Felixoid
suggested changes
Apr 25, 2018
| error_string = error.decode('utf-8') | ||
|
|
||
| if 'fatal: Not a git repository' in error_string: | ||
| if 0 != gitsym.returncode: |
There was a problem hiding this comment.
this change broke prompt like (:de68074|✔) on detached HEAD
There was a problem hiding this comment.
If you'll add if isgit.returncode != 0:, then this code could be deleted
| @@ -10,9 +10,7 @@ | |||
| gitsym = Popen(['git', 'symbolic-ref', 'HEAD'], stdout=PIPE, stderr=PIPE) | |||
There was a problem hiding this comment.
There is most quick way to get info are we in git repo or not
isgit = Popen(['git', 'name-rev'], stdout=PIPE, stderr=PIPE)
_, _ = isgit.communicate()
if isgit.returncode != 0:
sys.exit(0)
IMO it should be right after import sys
|
The problem is that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using return code to find out if a folder is under git version control.