-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make this action mathlib-independent #17
Conversation
@oliver-butterley please review this PR. |
Thanks for the PR! Sorry it's taken a while for me to respond. Yes, great that it also handles more cases. I think at the moment there is part of the logic that isn't correct: At the moment the action updates the What is the right thing to do? Update |
latest (pre)release of Lean. |
I think
|
🤔 that could work. The mathlib post update hook which updates lean-toolchain doesn't always work but the only situations where I have seen it fail are when the current version of lean is too old. Consequently it is likely that your proposal is fine. Is there an easy way to update lean-toolchain to the latest released version of lean? We could query the github api for releases of lean and then use that. Unless there is an easy way built into lake? |
I think the command |
Yes, that's a great solution, nicely done! |
lake exe cache get || true | ||
lake build | ||
shell: bash | ||
uses: leanprover/lean-action@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: when new release of lean-action
come, this line should be updated.
I tested this action here: https://github.com/Seasawher/mk-exercise
Changed so that Lean version updates are also performed in repositories that are not downstream of mathlib.