-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Localized progress action messages. #704
Comments
We just had to update ProgressDialog.ProcessMessage to do: //messageRecord[0] - is reserved for FormatString value
var message = messageRecord[2].ToString();
if (message.IsNotEmpty())
CurrentAction.Text = message; |
Resolved using the above. |
It would appear that:
|
Wow, very unusual convention. Interesting how it handles the case when there are two formatting args:
or
|
It's really strange but it seems like
Meaning that your work around is exactly the fix that is needed. Reopening this issue... |
Can you elaborate? |
Is it the case that the values in the format strings are the indexes of the records to replace them with e.g:
becomes:
|
I also thought about that: wixsharp/Source/src/WixSharp.UI/ManagedUI/Forms/ProgressDialog.cs Lines 126 to 133 in 9b752b7
But it was a bit weird to display formatted rec[0] in on the dialog. So I opted to rec[2]. |
Yes I was thinking rather for the description message in the new MessageDialog feature #692 |
- Migrated to .NET4 as target runtime - ManagedUI progress message localization improvements triggered by #704
Release v1.11.1 * Issue #704: Question: Localized progress action messages. * Issue #696: ComponentCondition on CloseApplication doesn't appear to be working * Removed `ValidateAssemblyCompatibility`as no longer needed since .NET4.0 is arguably a better choice for the recommended runtime * Issue #604: Is it possible to suppress the "UAC prompt" text if UAC is not enabled? * Issue #701: FR: Access to 32/64bit registry keys in Custom Actions (using .NET3.5) * WixSharpVSIX (VS Templates): Release v1.8.3 - Migrated to .NET4.0 as target runtime - ManagedUI progress message localization improvements triggered by #704 * Added a `Property.Secure`: ```C# new Property("Gritting", "Hello World!"){ Secure = true }) ``` * More granular conditions for feature install/uninstall: ```C# var condition = feature.ShallInstall() && feature.IsInstalled(); ```
In the legacy wix based installer we used the following in our .wxl file:
Despite adding this to the wixsharp project, the action messages don't seem to be translated.
project.LocalizationFile = "en-us.wxl";
Is it still possible to use this mechanisim?
The text was updated successfully, but these errors were encountered: