Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong path to the AdminToolsFolder #580

Closed
Xaddan opened this issue Jan 23, 2019 · 1 comment
Closed

Wrong path to the AdminToolsFolder #580

Xaddan opened this issue Jan 23, 2019 · 1 comment
Labels
bug Done: waiting for release

Comments

@Xaddan
Copy link
Contributor

Xaddan commented Jan 23, 2019

In AsWixVarToPath AdminToolsFolder is registered as follows:

case "AdminToolsFolder": return Environment.SpecialFolder.CommonApplicationData.ToPath().PathJoin(@"Start Menu\Programs\Administrative Tools");

What corresponds to:

C:\ProgramData\Start Menu\Programs\Administrative Tools

KNOWNFOLDERID
image
The correct is:

case "AdminToolsFolder": return Environment.SpecialFolder.StartMenu.ToPath().PathJoin(@"Programs\Administrative Tools");
oleg-shilo pushed a commit that referenced this issue Jan 23, 2019
@lbs-contributor
- Issue #580: Wrong path to the AdminToolsFolder
5af59c9
@oleg-shilo oleg-shilo added the bug label Jan 23, 2019
@oleg-shilo
Copy link
Owner

Txs. Done. Will be available in the next release

@Xaddan Xaddan closed this as completed Jan 23, 2019
oleg-shilo pushed a commit that referenced this issue Mar 19, 2019
@lbs-contributor
Release v1.9.5
2e709b8 
* Added new XML injection extensions `WixProject.AddXml` and `WixProject.AddXmlElement`
* Issue #608: Create Shortcut on Desktop to dotnet.exe
* Issue #551: Cannot include extra .wxs as part of a bundle
* Issue #610: Warning when building two bundles in one setup
* Issue #604: Is it possible to suppress the "UAC prompt" text if UAC is not enabled?
* Issue #606:  Platform.x64 not marking some folders win64="yes"
* Issue #599: Files creating empty folders on Destination (2)
* Issue #599: Files creating empty folders on Destination
* Added `WixEntity.ComponentCondition` to assist with cases when WiX element does not have condition (e.g. `RegistryKey`). Triggered by issue #593
* Added support for attribute namespaces during XML auto serialization with `WixObject.ToXElement()`
* Issue #586: How to add bal:overridable for Variable with wix#
* Issue #591: Code signing timestamping fails if old Windows SDK is installed
* Issue #585: Question: Warning about auto-generated IDs
* Issue #580: Wrong path to the AdminToolsFolder
* Add MsuPackage Element
* Fix Condition Net462_Installed, Net47_Installed, Net471_Installed, Net472_Installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Done: waiting for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xaddan @oleg-shilo