Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct variable name of SequentialGuid initialization. #564

Closed
monty241 opened this issue Jan 9, 2019 · 1 comment
Closed

Correct variable name of SequentialGuid initialization. #564

monty241 opened this issue Jan 9, 2019 · 1 comment

Comments

@monty241
Copy link
Contributor

monty241 commented Jan 9, 2019

In WixGuid.cs it reads:

        /// <summary>
        /// Initializes a new instance of the <see cref="SequentialGuid"/> class.
        /// </summary>
        /// <param name="previousGuid">The previous GUID.</param>
        public SequentialGuid(Guid previousGuid)
        {
            CurrentGuid = previousGuid;
        }

I think this it meant:

        /// <summary>
        /// Initializes a new instance of the <see cref="SequentialGuid"/> class.
        /// </summary>
        /// <param name="initialGuid">The initial GUID value.</param>
        public SequentialGuid(Guid initialGuid)
        {
            CurrentGuid = initialGuid;
        }
@oleg-shilo
Copy link
Owner

Agree. Done.

oleg-shilo pushed a commit that referenced this issue Jan 19, 2019
* VS project templates - added packages.config files
* Added Condition-s for .NET Frameworks 4.7.1 and 4.7.2
* Issue #569: Updating WixSharp leads to malfuncion of SetEvVar
* Added support for `UI.Error` WiX element
* Issue #552: Question: Install 2 windows services in same installer
* Issue #541: Installing 2 Services in the same installer results in …
* Samples update
* Issue #560: Semantic difference between UninstallCondition and IsUninstalling
* Issue #564: Correct variable name of SequentialGuid initialization.
* Issue #562: Typo in Compiler.cs comments
* Issue #561: Typo in WixProject.cs
* Added missing namespace in custom dialog template, fixed comment.
* Added explicit `WixEntity.ComponentId` property
* Issue #551: Cannot include extra .wxs as part of a bundle
* Issue #542: ServiceInstaller.StartOn/StopOn/RemoveOn - Documentation bug
* Issue #544: Failed while processing WebSites; added support for `IISVirtualDir.AttributesDefinition`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants