Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consts to make arbitrary keyCodes more readable. #45

Open
raae opened this issue Jul 30, 2019 · 0 comments
Open

Use consts to make arbitrary keyCodes more readable. #45

raae opened this issue Jul 30, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@raae
Copy link
Collaborator

raae commented Jul 30, 2019

Per @martingri suggestion create consts on top of PageFlipper.

Ie:

const RIGHT_ARROW = 37 // or was it 39

The convention is to use capital letters and underscores like the example above.

@raae raae added this to the theme-jam-deadline milestone Jul 30, 2019
olavea added a commit that referenced this issue Jul 31, 2019
@raae raae removed this from the theme-jam-deadline milestone Jul 31, 2019
@raae raae added the enhancement New feature or request label Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants