Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure VERIFIED domains return true #937

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Ensure VERIFIED domains return true #937

merged 1 commit into from
Feb 1, 2022

Conversation

virgofx
Copy link
Contributor

@virgofx virgofx commented Feb 1, 2022 •
edited
Loading

Fixes: #930

Golang doesn't fall through in switch by default like other languages. Small oversight in previous PR.

  • Added additional tests for validation method

@virgofx virgofx force-pushed the mark/fix-okta-domain-fallthrough branch from eaa95c5 to 9bedad1 Compare February 1, 2022 21:21
@monde monde self-requested a review February 1, 2022 22:26
monde
monde approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for adding a test to prove the change.

@monde monde merged commit 5dd6985 into okta:master Feb 1, 2022
@virgofx virgofx deleted the mark/fix-okta-domain-fallthrough branch February 1, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monde monde monde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

okta_domain_verification reports error in-spite of the validationStatus: VERIFIED
2 participants
@virgofx @monde