Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine API rate limit path accounting #700

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Refine API rate limit path accounting #700

merged 3 commits into from
Oct 11, 2021

Conversation

monde
Copy link
Collaborator

@monde monde commented Oct 8, 2021

  • Fix logical flaw in path accounting for API rate limits
  • Increase test coverage for path accounting

@monde monde mentioned this pull request Oct 8, 2021
Closed
@monde
Copy link
Collaborator Author

monde commented Oct 8, 2021

@phi1ipp check out this PR

@phi1ipp
Copy link
Contributor

phi1ipp commented Oct 8, 2021

thank you @monde , looks good to me, but what do I know?! :)

@monde
Copy link
Collaborator Author

monde commented Oct 8, 2021

thank you @monde , looks good to me, but what do I know?! :)

@phi1ipp your debug log and regexp example helped me see that way!

@bogdanprodan-okta bogdanprodan-okta linked an issue Oct 8, 2021 that may be closed by this pull request
max_api_capacity not working properly #696
Closed
@bogdanprodan-okta bogdanprodan-okta merged commit 437380a into master Oct 11, 2021
@monde monde deleted the rate-limit-paths-optimization branch October 16, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phi1ipp phi1ipp phi1ipp left review comments

@bogdanprodan-okta bogdanprodan-okta bogdanprodan-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max_api_capacity not working properly
3 participants
@monde @phi1ipp @bogdanprodan-okta