Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: okta_group_memberships #427

Merged
merged 13 commits into from
Apr 30, 2021

Conversation

ymylei
Copy link
Contributor

@ymylei ymylei commented Apr 15, 2021

The compliment to #416, except with the opposite relationship pattern.

  • Creates okta_group_memberships, using the group listing endpoints for validation membership (instead of the user listing endpoints used in New Resource: User Group Memberships #416).
  • Deprecates okta_group_membership in favor of using this or okta_user_group_memberships

@ymylei
Copy link
Contributor Author

ymylei commented Apr 20, 2021

➜  terraform-provider-okta git:(group_memberships) make testacc TEST=./okta TESTARGS='-run=TestAccOktaGroupMemberships_crud'
go mod tidy
go mod vendor
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./okta -v -run=TestAccOktaGroupMemberships_crud  -timeout 120m
=== RUN   TestAccOktaGroupMemberships_crud
--- PASS: TestAccOktaGroupMemberships_crud (26.19s)
PASS
ok  	github.com/okta/terraform-provider-okta/okta	26.515s

@ymylei
Copy link
Contributor Author

ymylei commented Apr 20, 2021

➜  terraform-provider-okta git:(group_memberships) make testacc TEST=./okta TESTARGS='-run=TestAccOktaUserGroupMemberships_crud'
go mod tidy
go mod vendor
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./okta -v -run=TestAccOktaUserGroupMemberships_crud  -timeout 120m
=== RUN   TestAccOktaUserGroupMemberships_crud
--- PASS: TestAccOktaUserGroupMemberships_crud (22.69s)
PASS
ok  	github.com/okta/terraform-provider-okta/okta	23.000s

@ymylei ymylei marked this pull request as ready for review April 20, 2021 17:35
@joshowen
Copy link
Contributor

We are extremely excited about this and the huge speedups it will bring our plans and applies. Thank you for making this change!

@bogdanprodan-okta bogdanprodan-okta merged commit 11ba6e8 into okta:master Apr 30, 2021
@ymylei ymylei deleted the group_memberships branch April 30, 2021 18:08
@joshowen
Copy link
Contributor

Hey @bogdanprodan-okta is there an ETA on the next Okta Provider release? We're extremely excited to pull this in, given the huge speedups we'll likely see. Thank you for all of the work you are doing on this provider!

@bogdanprodan-okta
Copy link
Contributor

Hi, @joshowen! Nope, no news from Hashicorp whatsoever :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants