Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes: Okta Group Role 404 Supression #417

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

ymylei
Copy link
Contributor

@ymylei ymylei commented Apr 8, 2021

This adds some resource existence checks and 404 suppression in some appropriate places for this resource, in case the top level group or targeted resources are deleted out of band or before this resource is aware of it.

@ymylei
Copy link
Contributor Author

ymylei commented Apr 8, 2021

tom@DESKTOP-NNSTVLT:~/terraform-provider-okta$ make testacc TEST=./okta TESTARGS='-run=TestAccOktaGroupAdminRole_crud'
go mod tidy
go mod vendor
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./okta -v -run=TestAccOktaGroupAdminRole_crud  -timeout 120m
=== RUN   TestAccOktaGroupAdminRole_crud
--- PASS: TestAccOktaGroupAdminRole_crud (21.06s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    21.067s

@bogdanprodan-okta
Copy link
Contributor

Hi, @ymylei! Thanks for submitting this PR! I'll review it asap.

@bogdanprodan-okta bogdanprodan-okta merged commit 6ddf5aa into okta:master Apr 9, 2021
@ymylei ymylei deleted the group_role_supression branch April 15, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants