Removed 'ForceNew' in case policy name changes #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretterer
reviewed
Mar 3, 2021
| @@ -3,7 +3,7 @@ data "okta_group" "all" { | |||
| } | |||
|
|
|||
| resource "okta_policy_mfa" "test" { | |||
| name = "testAcc_replace_with_uuid" | |||
| name = "testAcc_replace_with_uuid_new" | |||
There was a problem hiding this comment.
Just cuious what the reason for this change is
There was a problem hiding this comment.
I needed to make sure that the name will change.
bretterer
approved these changes
Mar 3, 2021
eatplaysleep
added a commit
to eatplaysleep/terraform-provider-mgm_okta
that referenced
this pull request
Mar 8, 2021
* Custom swa app (okta#328) * Set AUTO_LOGIN as sign_on mode for predefined apps * Force 'okta_app_user_schema' resource recreate when changing scope (okta#331) * Fix 'terraform plan' in case delete_when_absent is set to 'false' (okta#332) * Fixed validation for 'login_mode' and 'login_scopes' (okta#333) * Add 5 second wait after create * Added okta_auth_server_scopes datasource (okta#336) * Added social IdP data source (okta#337) * Fixed error handling (okta#338) * Moved validation for okta_app_oauth out of CustomizeDiff (okta#340) * Fixed group role when removing all the items from target_group_list (okta#341) Fixed group role when removing all the items from target_group_list * Added retry for role re-assignment * Formating * Improved retry logic * Build fix * Added extra code * Added changelog * Remove extra space * Fixed okta_idp_oidc subject_match_attribute value setup * use loop to perform multiple retries of find * Use backoff lib per bogdanprodan-okta * Update error messages * Only set ID at end once search for user passes * Bump actions/stale from v3.0.16 to v3.0.17 Bumps [actions/stale](https://github.com/actions/stale) from v3.0.16 to v3.0.17. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3.0.16...996798e) Signed-off-by: dependabot[bot] <[email protected]> * Retain user group app assignments (okta#330) Add option to retain `okta_app_group_assignment` and `okta_app_user` on destroy. * Fixed validation for several resources (okta#348) * Added 'target_app_list' to the 'okta_group_role' resource (okta#349) Added 'target_app_list' to the 'okta_group_role' resource * Added 'OVERRIDE' master property (okta#351) * Fixed setup for default scope (okta#352) * Fixed setup for deafult scope * Fixed vet * Updated CHANGELOG (okta#354) Updated CHANGELOG * Changelog (okta#355) Updated CHANGELOG * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.4.3 to 2.4.4 (okta#357) Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.4.3 to 2.4.4. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/master/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.4.3...v2.4.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Removed redundant method (okta#358) Removed redundant method * Added new formatting tool, remove unused dep (okta#360) * Add api scopes (okta#356) Add resource okta_app_oauth_api_scope * Removed 'ForceNew' in case policy name changes (okta#362) Removed 'ForceNew' in case policy name changes * Added hotp factor to the Okta MFA policy (okta#363) Added hotp factor to the okta mfa policy * Fixed error handler (okta#366) * Fixed error handler * Removed validation for 'single_logout_issuer' * Bump actions/stale from v3.0.17 to v3.0.18 (okta#371) Bumps [actions/stale](https://github.com/actions/stale) from v3.0.17 to v3.0.18. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3.0.17...3b3c3f0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bogdanprodan-okta <[email protected]> Co-authored-by: Tom Goodsell <[email protected]> Co-authored-by: Bogdan Prodan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Zoetewey <[email protected]> Co-authored-by: Marius Sturm <[email protected]>
eatplaysleep
added a commit
to eatplaysleep/terraform-provider-mgm_okta
that referenced
this pull request
Mar 8, 2021
* Custom swa app (okta#328) * Set AUTO_LOGIN as sign_on mode for predefined apps * Force 'okta_app_user_schema' resource recreate when changing scope (okta#331) * Fix 'terraform plan' in case delete_when_absent is set to 'false' (okta#332) * Fixed validation for 'login_mode' and 'login_scopes' (okta#333) * Add 5 second wait after create * Added okta_auth_server_scopes datasource (okta#336) * Added social IdP data source (okta#337) * Fixed error handling (okta#338) * Moved validation for okta_app_oauth out of CustomizeDiff (okta#340) * Fixed group role when removing all the items from target_group_list (okta#341) Fixed group role when removing all the items from target_group_list * Added retry for role re-assignment * Formating * Improved retry logic * Build fix * Added extra code * Added changelog * Remove extra space * Fixed okta_idp_oidc subject_match_attribute value setup * use loop to perform multiple retries of find * Use backoff lib per bogdanprodan-okta * Update error messages * Only set ID at end once search for user passes * Bump actions/stale from v3.0.16 to v3.0.17 Bumps [actions/stale](https://github.com/actions/stale) from v3.0.16 to v3.0.17. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3.0.16...996798e) Signed-off-by: dependabot[bot] <[email protected]> * Retain user group app assignments (okta#330) Add option to retain `okta_app_group_assignment` and `okta_app_user` on destroy. * Fixed validation for several resources (okta#348) * Added 'target_app_list' to the 'okta_group_role' resource (okta#349) Added 'target_app_list' to the 'okta_group_role' resource * Added 'OVERRIDE' master property (okta#351) * Fixed setup for default scope (okta#352) * Fixed setup for deafult scope * Fixed vet * Updated CHANGELOG (okta#354) Updated CHANGELOG * Changelog (okta#355) Updated CHANGELOG * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.4.3 to 2.4.4 (okta#357) Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.4.3 to 2.4.4. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/master/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.4.3...v2.4.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Removed redundant method (okta#358) Removed redundant method * Added new formatting tool, remove unused dep (okta#360) * Add api scopes (okta#356) Add resource okta_app_oauth_api_scope * Removed 'ForceNew' in case policy name changes (okta#362) Removed 'ForceNew' in case policy name changes * Added hotp factor to the Okta MFA policy (okta#363) Added hotp factor to the okta mfa policy * Fixed error handler (okta#366) * Fixed error handler * Removed validation for 'single_logout_issuer' * Bump actions/stale from v3.0.17 to v3.0.18 (okta#371) Bumps [actions/stale](https://github.com/actions/stale) from v3.0.17 to v3.0.18. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3.0.17...3b3c3f0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bogdanprodan-okta <[email protected]> Co-authored-by: Tom Goodsell <[email protected]> Co-authored-by: Bogdan Prodan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Zoetewey <[email protected]> Co-authored-by: Marius Sturm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #55