Correct change detection on resources okta_app_oauth_post_logout_redirect_uri and okta_app_oauth_redirect_uri
#1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`okta_app_oauth_redirect_uri` which did not implementation correct create/read/update/delete contexts for proper Terraform change detection. DRY up common code between these two resources. Closes #1283
duytiennguyen-okta
approved these changes
Oct 31, 2023
`okta_app_oauth_redirect_uri` as deprecated. These convenience resources are outside of good design principles for Terraform plugins. The desired behavior exists on the owning oauth app resource and reduces potential for change drift side effects.
duytiennguyen-okta
deleted the
1283_corrected_okta_app_oauth_redirect_uri
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting resources
okta_app_oauth_post_logout_redirect_uriandokta_app_oauth_redirect_uriwhich did not implement correct create/read/update/delete contexts for proper Terraform change detection. DRY up common code between these two resources.okta_app_oauth_post_logout_redirect_uriandokta_app_oauth_redirect_urihave been marked as deprecated. These convenience resources are outside of good design principles for Terraform plugins. The desired behavior exists on the owning oauth app resource and reduces potential for change drift side effects.Closes #1283