add support for brand creation #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tien Nguyen <[email protected]>
Signed-off-by: Tien Nguyen <[email protected]>
duytiennguyen-okta
changed the title
monde
requested changes
Aug 24, 2023
There was a problem hiding this comment.
I like the the brand refactor to TF plugin framework, nice work. I'm concerned about the expiration argument that pointed on the email domain resource. Also, additions to the PR description will be good to have both for code review now, and for bug hunting in the future.
monde
approved these changes
Aug 24, 2023
Merged
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for brand creation and convert brand resource to plugin framework
Update resource to match new sdk attribute