DRY up backoff.Backoff set up and proper use of context.Context #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly construct with the calling context for proper interruption handling.
production and test environments.
arguments that are being run.
MikeMondragon-okta
force-pushed
the
disable_backoff_for_vcr_tests
branch
from
b0a10a3 to
fab2f72
Compare
duytiennguyen-okta
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR DRY's up setting up backoff.Backoff where we needed to do API retries in various resources. It also correctly makes use of the calling context when setting up backoff which we hadn't be doing in most of the instances. The refactor was originally to make our VCR test recording run more quickly but exposed that we weren't making proper use of context with backoffs.
A time operations interface is added to the config to allow changing clock behavior to be more efficient in a test environment.
This is a refactor that sets up saving about 28% time recording VCR tests and speeds up replaying by 4x.