-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source: okta_group_rule #1606
Conversation
As an unrelated note, I'd love to hear more about this module you've built |
I like this PR thanks @steveAG . I'm playing tag with @duytiennguyen-okta to write an ACC test for it. |
@steveAG we are taking this PR and @duytiennguyen-okta is going to write an ACC test for it. But we need to you to send in an Okta Individual Contributor License Agreement
|
Thanks @monde, I signed & emailed the CLA on Sunday when submitting the PR because I saw it called out on other PRs, so we should be all set on that front. @exitcode0 Sorry I'm not ignoring the above request, I think I found a cleaner approach that solves some edge cases and doesn't depend on our org-specific metadata, so I'm doing a bit of a re-write to test that and should have some details tomorrow/Sat depending on whether that approach works. To be clear this doesn't impact the PR. |
I see it, apologies for pinging you about unnecessarily. |
Brought this via #1617 it will be in the next release. Thanks @steveAG , thanks @exitcode0 |
Awesome, thanks @monde! |
Adds a new data source to retrieve a group rule.
We're using this to build an optional safety check in our application module to reduce the impact of unexpected mass unassign from a high-impact application.