Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: okta_group_rule #1606

Closed
wants to merge 3 commits into from

Conversation

steveAG
Copy link
Contributor

@steveAG steveAG commented Jun 25, 2023

Adds a new data source to retrieve a group rule.

We're using this to build an optional safety check in our application module to reduce the impact of unexpected mass unassign from a high-impact application.

  • Read the current rule state (new data source) and compare it to the provided expression input variable to detect an expression change.
  • Use a resource precondition to block apply on expression change if user de-provisioning is enabled for the associated application (read from the existing application data source).

@steveAG steveAG changed the title New data source: okta_group_rule [WIP] New data source: okta_group_rule Jun 26, 2023
@steveAG steveAG changed the title [WIP] New data source: okta_group_rule New data source: okta_group_rule Jun 26, 2023
@exitcode0
Copy link
Contributor

As an unrelated note, I'd love to hear more about this module you've built

@monde
Copy link
Collaborator

monde commented Jun 28, 2023

I like this PR thanks @steveAG . I'm playing tag with @duytiennguyen-okta to write an ACC test for it.

@monde
Copy link
Collaborator

monde commented Jun 28, 2023

@steveAG we are taking this PR and @duytiennguyen-okta is going to write an ACC test for it. But we need to you to send in an Okta Individual Contributor License Agreement

@steveAG
Copy link
Contributor Author

steveAG commented Jun 29, 2023

Thanks @monde, I signed & emailed the CLA on Sunday when submitting the PR because I saw it called out on other PRs, so we should be all set on that front.

@exitcode0 Sorry I'm not ignoring the above request, I think I found a cleaner approach that solves some edge cases and doesn't depend on our org-specific metadata, so I'm doing a bit of a re-write to test that and should have some details tomorrow/Sat depending on whether that approach works. To be clear this doesn't impact the PR.

@monde
Copy link
Collaborator

monde commented Jun 29, 2023

Thanks @monde, I signed & emailed the CLA on Sunday when submitting the PR because I saw it called out on other PRs, so we should be all set on that front.

I see it, apologies for pinging you about unnecessarily.

MikeMondragon-okta pushed a commit that referenced this pull request Jun 29, 2023
@monde
Copy link
Collaborator

monde commented Jun 29, 2023

Brought this via #1617 it will be in the next release. Thanks @steveAG , thanks @exitcode0

@monde monde mentioned this pull request Jun 29, 2023
@steveAG
Copy link
Contributor Author

steveAG commented Jun 29, 2023

Awesome, thanks @monde!

@steveAG steveAG deleted the group-rule-datasource branch June 30, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants