Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to v3 and move v2 to local sdk #1500

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

duytiennguyen-okta
Copy link
Contributor

@duytiennguyen-okta duytiennguyen-okta commented Mar 22, 2023

We are upgrading from v2 to v3 of okta/okta-sdk-golang. Our strategy here is to avoid changing all sdk references at one time, putting us at risk of bugs, is to vendor local v2 and slowly remove those files as we switch over to v3.

@duytiennguyen-okta duytiennguyen-okta marked this pull request as draft March 22, 2023 15:17
@duytiennguyen-okta duytiennguyen-okta force-pushed the OKTA-591377-update-to-go-sdk-v3 branch from 3173caf to 5c10aa5 Compare March 22, 2023 19:27
@duytiennguyen-okta duytiennguyen-okta force-pushed the OKTA-591377-update-to-go-sdk-v3 branch from 5c10aa5 to 9f5bcef Compare March 22, 2023 19:55
@duytiennguyen-okta duytiennguyen-okta marked this pull request as ready for review March 22, 2023 20:14
@duytiennguyen-okta duytiennguyen-okta force-pushed the OKTA-591377-update-to-go-sdk-v3 branch from 138fdf3 to 30e4042 Compare March 23, 2023 15:11
@duytiennguyen-okta duytiennguyen-okta changed the base branch from master to v4.0.0 March 23, 2023 15:22
Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image == fun times

:shipit:

@duytiennguyen-okta duytiennguyen-okta merged commit d6e71ed into v4.0.0 Mar 23, 2023
@duytiennguyen-okta duytiennguyen-okta deleted the OKTA-591377-update-to-go-sdk-v3 branch March 23, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants