Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export the app embed url for saml apps #1215

Merged
merged 7 commits into from
Jul 29, 2022

Conversation

felixcolaci
Copy link
Contributor

Hi.
When trying to use the embed url of my saml application in the terraform context I noticed that it hasn't been exported yet.

I suggest to export it as an additional attribute so users are able to use that in their automations. This comes in handy fore example if you want to set this url as a configuration value in another application that is orchestrated with the same terraform playbook.

The goal is that it can be used like so:

output "embed_url" {
  value = okta_app_saml.secure_app.embed_url
}

Let me know what you think! Cheers.

Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @felixcolaci , thank you

@monde monde merged commit 5a613b1 into okta:master Jul 29, 2022
This was referenced Jul 29, 2022
@monde
Copy link
Collaborator

monde commented Jul 29, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants