-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds customizable Timeouts to resources/data that rely on syncing users and groups to avoid context.DeadlineExceeded #1207
Conversation
Thanks for the PR @emanor-okta . I'll be able to look at this closer later in the week. |
@emanor-okta disabling timeouts on all the C/R/U's of CRUD doesn't feel right to me. If that was the proper behavior then the TF SDK would ship with that as its default. Instead, this PR is a substantial behavior change and flips the onus on to the operator to set |
@monde - It would be possible to also make the timeout value be 20 minutes |
@monde - I removed the Timeout block from the data_source config files and website files. |
I wrote the ACC tests for this #1267 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACC tests for resource changes in PR #1207
[WIP] Adds customizable Timeouts to resources/data that rely on syncing users and groups (https://www.terraform.io/plugin/sdkv2/resources/retries-and-customizable-timeouts)
Changes the default timeouts from 20min to 1 year (no timeout) for application resources that can sync user/group memberships. This should resolve issues with running into
context.DeadlineExceeded
during the plan/apply phase for Orgs/Apps with large user assignments that don't use federation broker mode.Addresses issue #1101