feat: add keys
attribute to okta_app_saml
resource
#1206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
keys
attribute to theokta_app_saml
resource. We've put the methods used to pull the data intoapp.go
, so it could potentially be added to otherokta_app_*
resources, and also their matching data sources.Our use case is in setting up
org2org
with OAuth, where we'd like to create anokta_app_saml
resource in one organization, and anokta_app_oauth
service app in the other.Without the
keys
attribute, we've resorted to manually calling the/credentials/keys
endpoint and adding them as JWK blocks inokta_app_oauth
. We'd prefer to have this process be as automated as possible, so adding thekeys
to the application resource made sense to us.