Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom_profile_attributes to data_source_okta_groups #1033

Closed
wants to merge 3 commits into from

Conversation

exitcode0
Copy link
Contributor

fix #1009
code was mostly inspired by existing code in the repo at resource_okta_group.go#L128-L133

Still very new to Go and TF providers, so if this implementation is sub-par please let me know 😄

intended to work with the below example config

data "okta_groups" "test" {
  type = "OKTA_GROUP"
}

output "test" {
  value = [for group in data.okta_groups.test.groups : group.name if lookup(jsondecode(group.profile), "admin", false) == true]
}

@monde monde self-requested a review March 30, 2022 21:24
@monde
Copy link
Collaborator

monde commented Mar 30, 2022

I overlooked this PR @exitcode0 , I'll try to get it some attention soon-ish.

@monde
Copy link
Collaborator

monde commented Mar 31, 2022

@exitcode0 I cherry picked your code into a new branch #1041 so I could add to it and have our CI run on the changes. I'll close this PR for that.

@monde monde closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose custom group attributes in data_source_okta_groups
2 participants