Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo shows diffs if files renamed, even if unchanged. #1036

Closed
bobtfish opened this issue Mar 29, 2022 · 3 comments
Closed

logo shows diffs if files renamed, even if unchanged. #1036

bobtfish opened this issue Mar 29, 2022 · 3 comments
Assignees

Comments

@bobtfish
Copy link
Contributor

bobtfish commented Mar 29, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.13.7

Affected Resource(s)

  • okta_app_basic_auth
  • okta_app_bookmark
  • okta_app_oauth
  • okta_app_saml

Terraform Configuration Files

resource "okta_app_saml" "example" {
  ...
  logo = "example.png"
  ...
}

Expected Behavior

Resource does not show diffs if logo file is renamed without any other changes

Actual Behavior

Resource shows diff/change if logo is renamed

Steps to Reproduce

  1. Create an application with Terraform, including a logo file.
  2. terraform apply
  3. mv example_logo.png new_example_logo.png
  4. Change code to reference the new logo file
  5. terraform plan

Expect to see no changes (as the logo itself has not changed, just the location on the local filesystem), do see changes.

  • #0000
bobtfish added a commit to bobtfish/terraform-provider-okta that referenced this issue Mar 29, 2022
Fixes okta#1036 by not tracking the logo path in the state and just tracking the hash.
@monde monde self-assigned this Mar 29, 2022
@monde
Copy link
Collaborator

monde commented Mar 29, 2022

Thanks for the PR #1037 @bobtfish , I'll take a look.

MikeMondragon-okta pushed a commit that referenced this issue Mar 29, 2022
Fixes #1036 by not tracking the logo path in the state and just tracking the hash.
@monde
Copy link
Collaborator

monde commented Mar 30, 2022

Addressed in #1039

@monde monde closed this as completed Mar 30, 2022
@bobtfish
Copy link
Contributor Author

Thanks for the super quick response @monde - much appreciated.

If we can get a point release in a timely fashion too that would be amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants