Skip to content

Commit

Permalink
Fixed TestAccAppOAuthApplication_postLogoutRedirectCrud . Doesn't see…
Browse files Browse the repository at this point in the history
…m like it ever tested correctly given the code changes?
  • Loading branch information
monde committed Mar 22, 2022
1 parent d6b0669 commit 8256eef
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion examples/okta_app_oauth_post_logout_redirect_uri/basic.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resource "okta_app_oauth" "test" {

// Since Okta forces us to create it with a redirect URI we have to ignore future changes, they will be detected as config drift.
lifecycle {
ignore_changes = [redirect_uris]
ignore_changes = [post_logout_redirect_uris]
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ resource "okta_app_oauth" "test" {

// Since Okta forces us to create it with a redirect URI we have to ignore future changes, they will be detected as config drift.
lifecycle {
ignore_changes = [redirect_uris]
ignore_changes = [post_logout_redirect_uris]
}
}

Expand Down
4 changes: 2 additions & 2 deletions okta/resource_okta_app_oauth_post_logout_redirect_uri_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ func TestAccAppOAuthApplication_postLogoutRedirectCrud(t *testing.T) {
Config: config,
Check: resource.ComposeTestCheckFunc(
createPostLogoutRedirectURIExists(resourceName),
resource.TestCheckResourceAttr(resourceName, "id", "https://www.example.com"),
resource.TestCheckResourceAttr(resourceName, "uri", "https://www.example.com"),
resource.TestCheckResourceAttr(resourceName, "id", "http://google.com"),
resource.TestCheckResourceAttr(resourceName, "uri", "http://google.com"),
resource.TestCheckResourceAttrSet(resourceName, "app_id"),
),
},
Expand Down

0 comments on commit 8256eef

Please sign in to comment.