Skip to content

Commit

Permalink
Fixes encoding issue in url param for search (#840)
Browse files Browse the repository at this point in the history
fixes encoding issue in url param for search params
  • Loading branch information
arvindkrishnakumar-okta authored Mar 23, 2023
1 parent 2d57062 commit 8c2f12d
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
import org.springframework.http.converter.HttpMessageConverter;
import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter;
import org.springframework.web.client.RestTemplate;
import org.springframework.web.util.DefaultUriBuilderFactory;

import java.io.BufferedReader;
import java.io.File;
Expand Down Expand Up @@ -429,6 +430,10 @@ private RestTemplate restTemplate(ClientConfiguration clientConfig) {
restTemplate.setErrorHandler(new ErrorHandler());
restTemplate.setRequestFactory(requestFactory(clientConfig));

DefaultUriBuilderFactory uriTemplateHandler = new DefaultUriBuilderFactory();
uriTemplateHandler.setEncodingMode(DefaultUriBuilderFactory.EncodingMode.VALUES_ONLY);
restTemplate.setUriTemplateHandler(uriTemplateHandler);

return restTemplate;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,32 @@ class UsersIT extends ITSupport {
assertThat(retrievedUser.id, equalTo(user.id))
}

@Test (groups = "group2")
@Scenario("user-with-plus-sign-in-email")
void filterUserTest() {
def password = 'Passw0rd!2@3#'
def firstName = 'John'
def lastName = 'hashtag'
def email = firstName + "+" + lastName + "@example.com"

UserApi userApi = new UserApi(getClient())

User user = UserBuilder.instance()
.setEmail(email)
.setFirstName(firstName)
.setLastName(lastName)
.setPassword(password.toCharArray())
.buildAndCreate(userApi)
registerForCleanup(user)
validateUser(user, firstName, lastName, email)

Thread.sleep(getTestOperationDelay())

List<User> users = userApi.listUsers(null, null, null, "profile.login eq \"${email}\"", null, null, null)

assertUserPresent(users, user)
}

@Test (groups = "group2")
@Scenario("user-role-assign")
void roleAssignTest() {
Expand Down

0 comments on commit 8c2f12d

Please sign in to comment.