Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes missing type declaration in downstream consumers #69

Closed
wants to merge 1 commit into from

Conversation

nib-bturner
Copy link

@nib-bturner nib-bturner commented Apr 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix (OBVIOUS FIX)
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Users are unable to consume the typescript types found in this package. This is due to the ./scripts/build.js file not copying the ./types/ directory to ./dist. Thus when the package is published, the types are missing for downstream consumers. See image below

image

Issue Number: N/A

What is the new behavior?

Users are able to consume types.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

The types directory was not being copied to the dist folder causing installations to not have any types available.
@nib-bturner nib-bturner marked this pull request as ready for review April 24, 2023 05:59
@tgfisher4
Copy link

tgfisher4 commented Dec 17, 2023

@jaredperreault-okta @vijetmahabaleshwar-okta You look to have been active in this repo recently. I would like to consume @okta/oidc-middleware types but am currently unable due to the issue addressed here. Any chance we can get this reviewed/merged/fixed and a new version of the package published so TypeScript users like myself can consume the SDK's types?

@sgtsquiggs
Copy link

+1

I am currently having to pin @okta/oidc-middleware to
github:okta/okta-oidc-middleware#834bc696bae21c1112d7c46063944e3e0dfb3666 due to this issue. The 5.2.0 release adds types but neglects to bundle them into the npm release.

@jaredperreault-okta
Copy link
Contributor

@nib-bturner @tgfisher4 @sgtsquiggs 5.2.1 was just released, which contains the types in the output bundle

@jaredperreault-okta
Copy link
Contributor

Merged in #75

@nib-bturner nib-bturner deleted the fix-types branch January 9, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants