This repository has been archived by the owner on Jan 26, 2025. It is now read-only.
fix: remove connect-ensure-login to avoid implicit req.session.returnTo change - OKTA-255316 #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu-okta
force-pushed
the
sw-oidc-middleware-remove-connect-ensure-login-dependency-OKTA-255316
branch
2 times, most recently
from
5870e43 to
b43d2ec
Compare
swiftone
reviewed
Apr 6, 2020
swiftone
reviewed
Apr 6, 2020
| @@ -35,7 +35,6 @@ | |||
| "dependencies": { | |||
| "@okta/configuration-validation": "^0.4.1", | |||
| "body-parser": "^1.18.2", | |||
| "connect-ensure-login": "^0.1.1", | |||
There was a problem hiding this comment.
Per https://oktawiki.atlassian.net/wiki/spaces/eng/pages/814532965/DevEx+JS+Repo+Notes this should update the version and include a CHANGELOG.
(Note that sign-in-widget follows different rules than the rest of our JS repos)
swiftone
approved these changes
Apr 6, 2020
…To change - OKTA-255316 Resolves: #209
shuowu-okta
force-pushed
the
sw-oidc-middleware-remove-connect-ensure-login-dependency-OKTA-255316
branch
from
855c7fa to
61a7174
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently
oidc-middlewareuse unmaintained packageconnect-ensure-loginas dependency, which implicitly changesreq.session.returnTovalue toreq.orginUrl || req.url.It cause loginCallback.afterCallback URL cannot be properly consumed by passport
Issue Number: #209
What is the new behavior?
Remove
oidc-middleware, then reimplementoidcUtil.ensureAuthenticatedfunction w/o changing 'req.session`Does this PR introduce a breaking change?
Other information
connect-ensure-login
Reviewers
@aarongranick-okta