Remove ariaLabel prop and use same translation close for dialog #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancunningham-okta
requested review from
KevinGhadyani-Okta,
benschell-okta and
chrispulsinelli-okta
as code owners
bryancunningham-okta
force-pushed
the
bc/OKTA-683644/dialog-close-translation
branch
from
60271d3 to
d050dfe
Compare
chrispulsinelli-okta
previously approved these changes
Jan 29, 2024
bryancunningham-okta
force-pushed
the
bc/OKTA-683644/dialog-close-translation
branch
from
3c9faa6 to
b72dee5
Compare
| @@ -111,7 +116,7 @@ const Dialog = ({ | |||
| <DialogTitle translate={translate}> | |||
| {title} | |||
| <Button | |||
| ariaLabel={ariaLabel} | |||
| ariaLabel={t("close.text")} | |||
There was a problem hiding this comment.
Do we need to fall back to the supplied one for now?
Also, if someone uses this prop, can we give them a warning / error at build time?
There was a problem hiding this comment.
This translation already exists for Toast so, I just used the same one. Not sure about warning at build time. No strong feelings either way
There was a problem hiding this comment.
I just wonder if we should warn users about this, if we detect they set the prop. We're pretty much dropping the value on the floor now.
There was a problem hiding this comment.
@chrispulsinelli-okta I'm fine with warning users, if that is what we want to do. How do I best accomplish that?
chrispulsinelli-okta
previously approved these changes
Jan 30, 2024
Co-authored-by: Kevin Ghadyani <[email protected]>
KevinGhadyani-Okta
approved these changes
Feb 1, 2024
bryancunningham-okta
deleted the
bc/OKTA-683644/dialog-close-translation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-683644
Summary
Testing & Screenshots