test on windows #398
Merged
test on windows #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh there's actually no support for python on these systems 😿. I'll see if I can find a workaround, but for now let's continue manual smoke testing. |
|
@kavigupta ping me when the PR is done? I might need to make some changes. |
mehrdadn
reviewed
Dec 26, 2019
| python: "3.7" | ||
| language: sh | ||
| before_install: | ||
| - choco install python --version=3.7.2 --params "/InstallDir:C:\\Python" |
There was a problem hiding this comment.
Minor, but you don't actually need the double-backslash. Backslashes stay as-is unless followed by one of very few characters (which I think is just dollar sign, quotes, or sometimes an exclamation point).
mehrdadn
reviewed
Dec 26, 2019
mehrdadn
suggested changes
Dec 26, 2019
mehrdadn
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.