Always load all protocols #278
Conversation
| @@ -354,7 +354,7 @@ def import_module(module): | |||
| self.mockImportModule.side_effect = import_module | |||
| self.mockFindFiles.return_value = [self.FILE1] | |||
|
|
|||
| self.makeAssignment() | |||
| self.assertRaises(ImportError, self.makeAssignment) | |||
There was a problem hiding this comment.
The rationale here is that previously an invalid protocol was a config error. Now it's a bug.
|
Does this mean that we won't need to add |
|
Yes to both. Is there a danger to letting students run |
|
I don't think so. I was just clarifying my own understanding. |
|
The only protocol I'm concerned about is Backup. It's perfectly valid for someone not want to use the backup protocol (data8 did this all last year) and with this PR there is no way to do so (without having the user add arguments every time). No other protocol prompts for authentication with a user flag specifying that they want to run that protocol. There are a few solutions:
|
knrafto
force-pushed
the
all-protocols
branch
from
c356ae1 to
b937ea1
Compare
|
Hmm how about omitting the endpoint entirely? |
|
We use the endpoint all over the place - in collab & hinting for example. If we can get a default value in there - so that using |
|
The endpoint now defaults to the empty string if omitted. If the endpoint is falsey, we won't attempt to backup. I tested the other protocols too manually, and nothing seemed to break. |
From now on we'll ignore the list of protocols in
protocols.