fix(Feature Flags): Use ListView instead of RecyclerView for a more r…

…eliable list.
okkidwi · Aug 18, 2024 · 6f16b7f · 6f16b7f
1 parent efdd59a
commit 6f16b7f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 50 deletions.
diff --git a/src/main/kotlin/crimera/patches/twitter/featureFlag/FeatureFlagPatch.kt b/src/main/kotlin/crimera/patches/twitter/featureFlag/FeatureFlagPatch.kt
@@ -25,11 +25,7 @@ object FeatureFlagPatch : BytecodePatch(
     setOf(
         FeatureFlagFingerprint,
         IntegrationsUtilsFingerprint,
-        SettingsStatusLoadFingerprint,
-        CustomAdapterFingerprint,
-        GetCountFingerprint,
-        OnCreateViewHolderFingerprint,
-        OnBindViewHolderFingerprint
+        SettingsStatusLoadFingerprint
     )
 ) {
     override fun execute(context: BytecodeContext) {
@@ -52,20 +48,5 @@ object FeatureFlagPatch : BytecodePatch(
         IntegrationsUtilsFingerprint.result!!.mutableMethod.addInstruction(
             1, "${SettingsPatch.FSTS_DESCRIPTOR}->load()V"
         )
-
-        // Change the getCount override method name
-        val customAdapter = CustomAdapterFingerprint.result
-            ?: throw PatchException("getCount Method of CustomAdapter not found")
-
-        customAdapter.mutableMethod.name = GetCountFingerprint.result?.method?.name
-            ?: throw PatchException("getCount Method of RecyclerView not found")
-
-        // onCreateViewHolder
-        customAdapter.mutableClass.methods.first { it.name == "onCreateViewHolder" }.name = OnCreateViewHolderFingerprint.result?.method?.name
-            ?: throw PatchException("onCreateViewHolder Method of RecyclerView not found")
-
-        // onBindViewHolder
-        customAdapter.mutableClass.methods.first { it.name == "onBindViewHolder" }.name = OnBindViewHolderFingerprint.result?.method?.name
-            ?: throw PatchException("onBindViewHolder Method of RecyclerView not found")
     }
 }
diff --git a/src/main/kotlin/crimera/patches/twitter/featureFlag/fingerprints/RecyclerViewFingerprints.kt b/src/main/kotlin/crimera/patches/twitter/featureFlag/fingerprints/RecyclerViewFingerprints.kt
diff --git a/src/main/resources/twitter/settings/layout/feature_flags_view.xml b/src/main/resources/twitter/settings/layout/feature_flags_view.xml
@@ -7,7 +7,7 @@
         android:layout_height="match_parent"
         android:id="@+id/linearLayout">
 
-    <androidx.recyclerview.widget.RecyclerView
+    <ListView
             android:id="@+id/list"
             android:layout_width="0dp"
             android:layout_height="0dp"