Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2529 - Fix the chat regression #2533

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

SebinSong
Copy link
Collaborator

closes #2529

[Fix screenshot - debugged using real DB data]

@SebinSong SebinSong self-assigned this Jan 22, 2025
Copy link

cypress bot commented Jan 22, 2025

group-income    Run #3782

Run Properties:  status check passed Passed #3782  •  git commit db55fd332f ℹ️: Merge 307411ac449b4221a42cc4f85c3ce2a556a29410 into 80397f453d35b65fbc683ecf6bff...
Project group-income
Branch Review sebin/task/#2529-chat-regression
Run status status check passed Passed #3782
Run duration 10m 57s
Commit git commit db55fd332f ℹ️: Merge 307411ac449b4221a42cc4f85c3ce2a556a29410 into 80397f453d35b65fbc683ecf6bff...
Committer Sebin Song
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

@SebinSong
Copy link
Collaborator Author

This fix does not break the previous fix:

image

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it seems like a bit of a hack, it seems to work well. 🧐

Congrats on figuring it out!

@taoeffect taoeffect merged commit fe77c20 into master Jan 22, 2025
4 checks passed
@taoeffect taoeffect deleted the sebin/task/#2529-chat-regression branch January 22, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One more chat regression
2 participants