#2518 - HTML rendering bug in BannerGeneral.vue
#2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebinSong
commented
Jan 21, 2025
| </template> | ||
|
|
||
| <script> | ||
| import TransitionExpand from '@components/TransitionExpand.vue' | ||
| import { debounce } from '@model/contracts/shared/giLodash.js' | ||
| import RenderMessageWithMarkdown from '@containers/chatroom/chat-mentions/RenderMessageWithMarkdown.js' |
There was a problem hiding this comment.
Using RenderMessageWithMarkdown.vue here is wrong (As it's a component built for chatroom) but regardless, it internally used v-safe-html custom directive which is the thing we need here. So I just replaced this component with a <div /> that uses this directive.
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2518-html-in-banner
|
| Run status |
|
| Run duration | 11m 04s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
112
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2518
[ Fix screenshot ]
Can see the
<a />tag is rendered correctly in the DOM.BTW, This comment mentions that #2139 introduced this bug but that is not correct...
That PR is a fix for chatroom-specific bugs and
RenderMessageWithMarkdown.vue(I built it) is not designed to be used inside a banner. So I think it's somewhere further up in the past commit history.