#202 Step 1 - Add Roles and permissions section UI on GroupSettings page
#2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es-and-permissions-step1
SebinSong
changed the title
SebinSong
changed the title
Roles and permissions section UI on GroupSettings page
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#202-roles-and-permissions-step1
|
| Run status |
|
| Run duration | 10m 49s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
112
|
| View all changes introduced in this branch ↗︎ | |
SebinSong
changed the title
Roles and permissions section UI on GroupSettings pageRoles and permissions section UI on GroupSettings page
taoeffect
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Nice work @SebinSong! Preliminary review ready (I haven't had a chance to do an in-depth review today)
Comment on lines
+83
to
+84
| roles-and-permissions | ||
|
|
There was a problem hiding this comment.
Can we have this section displayed only in development mode since it doesn't work and hide it in production?
There was a problem hiding this comment.
Sure, updated in here
|
Just made some additional updates:
|
…es-and-permissions-step1
…es-and-permissions-step1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of #202 Todo list: here
NOTE: This PR is UI implementation only. The data presented in the table are fake.
[ Desktop ]
[ Mobile ]