Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrideat/task/#2479 string comparison issue #2504

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

corrideat
Copy link
Member

Closes #2479

@corrideat corrideat self-assigned this Jan 12, 2025
@corrideat corrideat requested a review from taoeffect January 12, 2025 14:35
Copy link

cypress bot commented Jan 12, 2025

group-income    Run #3697

Run Properties:  status check passed Passed #3697  •  git commit a5557e0fb5 ℹ️: Merge 22a12bf5416c6586a1f273aea1ba8c625f23f39b into 94fc55de3a2c60173f0353f5c445...
Project group-income
Branch Review corrideat/task/#2479-string-comparison-issue
Run status status check passed Passed #3697
Run duration 10m 42s
Commit git commit a5557e0fb5 ℹ️: Merge 22a12bf5416c6586a1f273aea1ba8c625f23f39b into 94fc55de3a2c60173f0353f5c445...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

@corrideat corrideat force-pushed the corrideat/task/#2479-string-comparison-issue branch from 2406e72 to 22a12bf Compare January 12, 2025 18:16
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@taoeffect taoeffect merged commit 0486f23 into master Jan 13, 2025
4 checks passed
@taoeffect taoeffect deleted the corrideat/task/#2479-string-comparison-issue branch January 13, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Curly quotes" can prevent users from easily leaving group
3 participants