Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2465 #2500

Merged

Conversation

corrideat
Copy link
Member

@corrideat corrideat commented Jan 8, 2025

Addresses https://okturtles.slack.com/archives/C0EH7P20Y/p1736304255972969?thread_ts=1736288737.650779&cid=C0EH7P20Y.

EDIT (by @taoeffect): copying from Slack:

BTW, since merging the latest master in, when running grunt dev I get this infinite SW error saying chelonia/private/startClockSync has already been called which makes it unable to load the app. (Once clearing the Group Income--Settings data in the indexedDB, it's gone but I had to repeat it every time I run grunt dev again)

sw-error.mp4

Copy link

cypress bot commented Jan 8, 2025

group-income    Run #3657

Run Properties:  status check passed Passed #3657  •  git commit e9561296f7 ℹ️: Merge f15053d17ce456d318c4c8e6e155cfefa1b71a73 into 8d7d9a19a73d7d24b1d8c4614115...
Project group-income
Branch Review 2465-time-sync-doesnt-work-because-of-null-connectionurl
Run status status check passed Passed #3657
Run duration 10m 48s
Commit git commit e9561296f7 ℹ️: Merge f15053d17ce456d318c4c8e6e155cfefa1b71a73 into 8d7d9a19a73d7d24b1d8c4614115...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved emergency fix

@taoeffect taoeffect merged commit 191962e into master Jan 8, 2025
4 checks passed
@taoeffect taoeffect deleted the 2465-time-sync-doesnt-work-because-of-null-connectionurl branch January 8, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants