#2498 - Fix the link bug in the chat #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2498-chat-link-issue
|
| Run status |
|
| Run duration | 10m 47s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
112
|
| View all changes introduced in this branch ↗︎ | |
corrideat
reviewed
Jan 8, 2025
SebinSong
commented
Jan 9, 2025
| @@ -87,9 +88,14 @@ function createRecursiveDomObjects (element: any): DomObject { | |||
| nodeObj.children.push(createRecursiveDomObjects(child)) | |||
| } | |||
|
|
|||
| nodeObj.children = nodeObj.children.filter( | |||
| child => child.tagName || (child.text || '').trim().length | |||
There was a problem hiding this comment.
@taoeffect Had more thorough investigation for the original issue and found out trim() here was the cause of the issue. As far as I remember, this was added to remove unnecessary \n created from `DOMParser: parseFromString() API. So updated the logic here.
|
@taoeffect Updated the PR with the better fix 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2498